From e93ba25f2cd156a6544a3c9894cd667906146874 Mon Sep 17 00:00:00 2001 From: ipknHama Date: Mon, 18 Sep 2017 02:39:46 +0900 Subject: Fix cookie parsing: Cookie doesn't have escaping mechanism. --- tests/unittest.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'tests') diff --git a/tests/unittest.cpp b/tests/unittest.cpp index a85f7bc..303fa72 100644 --- a/tests/unittest.cpp +++ b/tests/unittest.cpp @@ -856,12 +856,16 @@ TEST(middleware_cookieparser) std::string value1; std::string value2; + std::string value3; + std::string value4; CROW_ROUTE(app, "/")([&](const request& req){ { auto& ctx = app.get_context(req); value1 = ctx.get_cookie("key1"); value2 = ctx.get_cookie("key2"); + value3 = ctx.get_cookie("key3"); + value4 = ctx.get_cookie("key4"); } return ""; @@ -869,7 +873,7 @@ TEST(middleware_cookieparser) decltype(app)::server_t server(&app, LOCALHOST_ADDRESS, 45451); auto _ = async(launch::async, [&]{server.run();}); - std::string sendmsg = "GET /\r\nCookie: key1=value1; key2=\"val\\\"ue2\"\r\n\r\n"; + std::string sendmsg = "GET /\r\nCookie: key1=value1; key2=\"val=ue2\"; key3=\"val\"ue3\"; key4=\"val\"ue4\"\r\n\r\n"; asio::io_service is; { asio::ip::tcp::socket c(is); @@ -882,7 +886,9 @@ TEST(middleware_cookieparser) } { ASSERT_EQUAL("value1", value1); - ASSERT_EQUAL("val\"ue2", value2); + ASSERT_EQUAL("val=ue2", value2); + ASSERT_EQUAL("val\"ue3", value3); + ASSERT_EQUAL("val\"ue4", value4); } server.stop(); } -- cgit v1.2.3-54-g00ecf