diff options
| author | Stefan Zabka <zabkaste@hu-berlin.de> | 2020-05-21 12:37:46 +0200 |
|---|---|---|
| committer | Stefan Zabka <zabkaste@hu-berlin.de> | 2020-05-21 12:37:46 +0200 |
| commit | dd4f3ec7551fddb88c5d6b96ed1aff3521c937ca (patch) | |
| tree | 97e603f80bde82372e0a1cbb4b70b8bfdace8740 /02_exercise/prompt_utils.c | |
| parent | f117343477e596937bdfcf0ddce447c0d127b9cf (diff) | |
| download | betriebssysteme-dd4f3ec7551fddb88c5d6b96ed1aff3521c937ca.tar.gz betriebssysteme-dd4f3ec7551fddb88c5d6b96ed1aff3521c937ca.zip | |
Added warning and cleaned them up
Diffstat (limited to '02_exercise/prompt_utils.c')
| -rw-r--r-- | 02_exercise/prompt_utils.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/02_exercise/prompt_utils.c b/02_exercise/prompt_utils.c index 4f86811..b7c836b 100644 --- a/02_exercise/prompt_utils.c +++ b/02_exercise/prompt_utils.c @@ -6,11 +6,11 @@ #include <string.h> #include <unistd.h> -char const *const relative_path(char const *const from_dir, char const *const to_dir) { +char const *relative_path(char const *const from_dir, char const *const to_dir) { + // easiest cases first { - int result = strcmp(from_dir, to_dir); - if (result == 0) { + if (strcmp(from_dir, to_dir) == 0) { char *return_value = malloc(2); strcpy(return_value, "."); return return_value; @@ -35,7 +35,7 @@ char const *const relative_path(char const *const from_dir, char const *const to size_t array_len = from_dir_len < to_dir_len ? from_dir_len : to_dir_len; size_t i = 0; size_t common_position = 0; - for (; i < array_len - 1; i++) { + for (; i < array_len - 1; ++i) { if (from_dir_indeces[i + 1] != to_dir_indeces[i + 1]) { break; } @@ -61,7 +61,7 @@ char const *const relative_path(char const *const from_dir, char const *const to strlen(go_up) * (levels_up - 1); return_value = malloc(length * sizeof(char)); strcpy(return_value, ".."); - for (size_t j = 0; j < levels_up - 1; j++) { + for (size_t j = 0; j < levels_up - 1; ++j) { strcat(return_value, go_up); } if (strcmp("/", to_dir) != 0) { |