Added a general purpose try-catch around handle() for instances where an exception would cause the server to never return a response. At some later date we would possibly still wish to provide a custom hook for dealing with 500s. Also note, after an exception is caught, the generated 500 response is still sent to middleware handlers

1 files changed, 19 insertions, 1 deletions

diff --git a/include/routing.h b/include/routing.h
index 9f607f1..79743cd 100644
--- a/include/routing.h
+++ b/include/routing.h
@@ -655,7 +655,25 @@ public:
 
             CROW_LOG_DEBUG << "Matched rule '" << ((TaggedRule<>*)rules_[rule_index].get())->rule_ << "' " << (uint32_t)req.method << " / " << rules_[rule_index]->methods();
 
-            rules_[rule_index]->handle(req, res, found.second);
+            // any uncaught exceptions become 500s
+            try
+            {
+                rules_[rule_index]->handle(req, res, found.second);
+            }
+            catch(std::exception& e)
+            {
+                CROW_LOG_ERROR << "An uncaught exception occurred: " << e.what();
+                res = response(500);
+                res.end();
+                return;   
+            }
+            catch(...)
+            {
+                CROW_LOG_ERROR << "An uncaught exception occurred. The type was unknown so no information was available.";
+                res = response(500);
+                res.end();
+                return;   
+            }
         }
 
         void debug_print()